Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-youcompleteme: fix python interpreter #73081

Merged
merged 2 commits into from Nov 9, 2019
Merged

Conversation

@LnL7
Copy link
Member

LnL7 commented Nov 8, 2019

Motivation for this change

The variables where renamed, perhaps it would be better to use a patch here instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@LnL7 LnL7 requested a review from jonringer as a code owner Nov 8, 2019
@ofborg ofborg bot added the 6.topic: vim label Nov 8, 2019
@LnL7 LnL7 force-pushed the LnL7:vim-youcompleteme branch from 0a08edb to 19c6b30 Nov 8, 2019
@ofborg ofborg bot requested a review from jagajaga Nov 8, 2019
Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
ycmd seems to work

[4 built, 16 copied (2364.4 MiB), 512.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73081
3 package were build:
rustracerd vimPlugins.youcompleteme ycmd
@jonringer jonringer merged commit 8e1380b into NixOS:master Nov 9, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rustracerd, vimPlugins.youcompleteme on aarch64-linux Success
Details
rustracerd, vimPlugins.youcompleteme on x86_64-darwin Success
Details
rustracerd, vimPlugins.youcompleteme on x86_64-linux Success
Details
@LnL7 LnL7 deleted the LnL7:vim-youcompleteme branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.