Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/users:added users.allowLoginless option #73082

Closed
wants to merge 3 commits into from

Conversation

@pasqui23
Copy link
Contributor

pasqui23 commented Nov 8, 2019

Motivation for this change

Fixes #73003
Also made security.initialRootPassword a renamed option

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from rycee Nov 8, 2019
@pasqui23 pasqui23 changed the title Loginless nixos/users:added users.allowLoginless option Nov 8, 2019
@@ -72,6 +72,7 @@ with lib;
(mkRemovedOptionModule [ "security" "setuidPrograms" ] "Use security.wrappers instead")

(mkRenamedOptionModule [ "security" "virtualization" "flushL1DataCache" ] [ "security" "virtualisation" "flushL1DataCache" ])
(mkRenamedOptionModule ["security" "initialRootPassword"] ["users" "users" "root" "initialHashedPassword"])

This comment has been minimized.

Copy link
@flokli

flokli Nov 8, 2019

Contributor

please add this to nixos/modules/config/users-groups.nix instead, like done in other places - we intend to move away from a global rename.nix.

@@ -6,13 +6,13 @@
stdenv.mkDerivation rec {

pname = "home-manager";
version = "2019-10-23";
version = "2019-10-29";

This comment has been minimized.

Copy link
@flokli

flokli Nov 8, 2019

Contributor

this probably isn't related, and should go in a separate PR ;-)

@pasqui23

This comment has been minimized.

Copy link
Contributor Author

pasqui23 commented Nov 9, 2019

Closed in favor of #73106

@pasqui23 pasqui23 closed this Nov 9, 2019
@pasqui23 pasqui23 deleted the pasqui23:loginless branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.