Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
groff: Fix cross-compilation #73088
Fixup the patch from 4f3c817 so it
The patch was removed, but cross-compilation not validated, in #70500.
Motivation for this change
Quite obviously, to fix cross-compilation of groff!
I'm very sorry about breaking cross-compilation, how do you recommend I avoid that in the future?
I'll be more careful about patches that don't seem to matter, but how should one actually test cross-compilation? For which host-target combinations? (Any combination is better than none?)
It happens, and it will happen. I don't think we have the tooling, and especially, the required metadata to know. Don't beat yourself up too much :).
I may be wrong, and definitely am biased, but I would assume armv7l and/or aarch64 from an x86_64 host is sufficient, unless noted (how?) otherwise. There's also the greater issue of building for musl, rather than gnu, which I now realize I don't really know about.