Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libco-canonical: v19.1 -> v20 #73089

Merged
merged 1 commit into from Nov 9, 2019
Merged

libco-canonical: v19.1 -> v20 #73089

merged 1 commit into from Nov 9, 2019

Conversation

@lodi
Copy link
Contributor

lodi commented Nov 9, 2019

Motivation for this change

Version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @wucke13

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
lxd executables still seem to work

[6 built, 13 copied (34.8 MiB), 25.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73089
3 package were build:
dqlite libco-canonical lxd
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 9, 2019

@GrahamcOfBorg build dqlite libco-canonical lxd

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 9, 2019

darwin failing to build lxd makes sense

@jonringer jonringer merged commit 5e70be0 into NixOS:master Nov 9, 2019
18 checks passed
18 checks passed
dqlite, libco-canonical, lxd on aarch64-linux Failure
Details
dqlite, libco-canonical, lxd on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
dqlite, libco-canonical, lxd on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libco-canonical on aarch64-linux Success
Details
libco-canonical on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.