Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequoia: 0.10.0 -> 0.11.0 #73104

Merged
merged 1 commit into from Nov 21, 2019
Merged

sequoia: 0.10.0 -> 0.11.0 #73104

merged 1 commit into from Nov 21, 2019

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented Nov 9, 2019

Motivation for this change

Closes #70646.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @minijackson

@minijackson

This comment has been minimized.

Copy link
Contributor

minijackson commented Nov 9, 2019

Hey, thank you for the update!

Can you tell me more on how this fixes #70646?

@minijackson

This comment has been minimized.

Copy link
Contributor

minijackson commented Nov 9, 2019

Unfortunately, nix-review fails with me, with a No space left on device error, so I can't test it :-/

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 9, 2019

Unfortunately, nix-review fails with me, with a No space left on device error, so I can't test it :-/

Do you happen to be using boot.tmpOnTmpfs? If so, then you need something along the lines of:

    # Use an a tmpdir with unlimited space (as opposed to /tmp)
    systemd.services."nix-daemon".environment.TMPDIR = "/nix/tmp";

BTW, my cachix has a build of this derivation.

Can you tell me more on how this fixes #70646?

TBH, and @worldofpeace should be cc'd, I don't know why it failed on hydra in the first place, as it always builds locally. it seems to be only a matter of resources, hence the removed broken flag. If it'll keep fail on hydra, I think the matter should be treated by someone with access to hydra's settings. See my comment: #70646 (comment) .

@risicle

This comment has been minimized.

Copy link
Contributor

risicle commented Nov 9, 2019

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 9, 2019

Hmm, interesting, did you try to build python3Packages.sequoia or just sequoia? A Google search implies this is a common python issue with older versions of SSL and / or the missing security optional dependency for Python...

@risicle

This comment has been minimized.

Copy link
Contributor

risicle commented Nov 9, 2019

Both gave a similar error.

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 9, 2019

Could you please disable the tests doCheck = false and see if the executables are functional?

@risicle

This comment has been minimized.

Copy link
Contributor

risicle commented Nov 9, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Nov 9, 2019

I guess failing on macos is a different issue.

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 10, 2019

So @worldofpeace shall we disable tests for MacOS only in the meantime?

@risicle

This comment has been minimized.

Copy link
Contributor

risicle commented Nov 10, 2019

The tests aren't the problem on macos.

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 10, 2019

Well I have no way to debug this for MacOS. what perplexes me though is that the 2 gists you've published indicate a different issue every time. What was the different between the 2 attempts?

@risicle

This comment has been minimized.

Copy link
Contributor

risicle commented Nov 10, 2019

The first time doCheck was true, the second doCheck was false, as you asked.

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 10, 2019

The first time doCheck was true, the second doCheck was false, as you asked.

I see. If no MacOS user would like to fix this issue, then I'm marking the package as broken only for MacOS. See 3a7bbb6 .

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Nov 10, 2019

@doronbehar Yeah, it's looking like a bit of a hassle. We can just do as I suggested as an alternative in a09e3e2, which is to drop that commit and just disable checkPhase. We can communicate with upstream.

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 11, 2019

@worldofpeace what do you think about @curiousleo's suggestion:

Build time > 3600 seconds (with Python bindings) seems excessive - I've reported this upstream: https://gitlab.com/sequoia-pgp/sequoia/issues/357

?

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 15, 2019

BTW @worldofpeace setting the ulimit fails the build locally for me, with:

/nix/store/kirg08m7yzlp226q7ki61q9j5zjf1x9p-stdenv-linux/setup: line 97: ulimit: open files: cannot modify limit: Operation not permitted

Pushed a revert.

@minijackson

This comment has been minimized.

Copy link
Contributor

minijackson commented Nov 19, 2019

(I've just noticed, but your commit message and PR title indicates the upgrade from 0.10.0 to 0.11.1, but the new version in the commit is 0.11.0 ) 😛

Disable check on Darwin.
@doronbehar doronbehar force-pushed the doronbehar:update-sequoia branch from c5688bb to 1dbcd8f Nov 19, 2019
@doronbehar doronbehar changed the title sequoia: 0.10.0 -> 0.11.1 sequoia: 0.10.0 -> 0.11.0 Nov 19, 2019
@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 19, 2019

Thanks @minijackson :)

@worldofpeace worldofpeace merged commit ac82d7a into NixOS:master Nov 21, 2019
15 checks passed
15 checks passed
sequoia on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sequoia on x86_64-linux Success
Details
@doronbehar doronbehar mentioned this pull request Dec 26, 2019
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.