Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/users:added users.allowLoginless #73106

Open
wants to merge 3 commits into
base: master
from
Open

Conversation

@pasqui23
Copy link
Contributor

pasqui23 commented Nov 9, 2019

Motivation for this change

Fixes #73003
Also made security.initialRootPassword a renamed option

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pstn

This comment has been minimized.

Copy link
Contributor

pstn commented Nov 9, 2019

Cool, what about allowing multiple users with the same UID? Should we make that a separate option?

@pasqui23

This comment has been minimized.

Copy link
Contributor Author

pasqui23 commented Nov 9, 2019

@pstn for that there is already users.enforceIdUniqueness

nixos/modules/config/users-groups.nix Outdated Show resolved Hide resolved
@@ -473,15 +475,15 @@ in {
'';
};

# FIXME: obsolete - will remove.

This comment has been minimized.

Copy link
@JohnAZoidberg

JohnAZoidberg Nov 10, 2019

Member

@edolstra, you put this comment - Is it okay to remove it like this?

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Dec 2, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.