Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/ceph: Clarify comments in tests and add source reference for the bootstraping method #73109

Closed
wants to merge 1 commit into from

Conversation

@lejonet
Copy link
Contributor

lejonet commented Nov 9, 2019

Motivation for this change

As is highlighted in #72603, the comments in the ceph tests weren't clear on why something were done. This PR adds more descriptive comments in the tests to avoid confusion in the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @srhb @johanot @flokli

…e bootstraping method
@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Nov 9, 2019

This might be obsoleted by the latest push to #72603.

@lejonet

This comment has been minimized.

Copy link
Contributor Author

lejonet commented Nov 9, 2019

This might be obsoleted by the latest push to #72603.

At least the first comment, the one describing the reason why we nuked the ceph.target. So perhaps what we should do is that we close this PR and you just port the comment before the testscript variable to #72603?

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Nov 9, 2019

I included the comment in #72603.

@flokli flokli closed this Nov 9, 2019
@lejonet lejonet deleted the lejonet:ceph-tests-comments branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.