Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/calibre-server: Add address configuration #73110

Open
wants to merge 1 commit into
base: master
from

Conversation

@endocrimes
Copy link
Member

endocrimes commented Nov 9, 2019

This commit introduces two new fields into the configuration of calibre-server, listenAddress and port. These allow the operator to configure the addresses that calibre should listen on, and the port it should bind to respectively.

The default values here are copied from calibre itself, to avoid backwards compatibility issues or more complicated service configuration.

Motivation for this change

calibre defaults to listening on port 8080 on all interfaces, which isn't ideal in almost any configuration outside of developing calibre itself. Exposing this configuration lets people run calibre more reasonably.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar @pSub @AndersonTorres

This commit introduces two new fields into the configuration of
calibre-server, listenAddress and port. These allow the operator to
configure the addresses that calibre should listen on, and the port it
should bind to respectively.

The default values here are copied from calibre itself, to avoid
backwards compatibility issues or more complicated service
configuration.
default = "::";
example = "127.0.0.1";
description = ''
The interface on which to listen for connections. The value "::" will

This comment has been minimized.

Copy link
@contrun

contrun Nov 16, 2019

Contributor

Should we change it to The address on which to listen for connections

This comment has been minimized.

Copy link
@endocrimes

endocrimes Nov 16, 2019

Author Member

Could do - I was keeping it inline with the upstream documentation for now, but don't feel strongly either way.

This comment has been minimized.

Copy link
@contrun

contrun Nov 23, 2019

Contributor

OK. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.