Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: 0.20.23 -> 0.21.16 #73112

Closed
wants to merge 1 commit into from
Closed

mpd: 0.20.23 -> 0.21.16 #73112

wants to merge 1 commit into from

Conversation

@phi-gamma
Copy link
Contributor

phi-gamma commented Nov 9, 2019

Motivation for this change
  • Bump version.
  • Drop obsolete patch.
  • Fix API changes that break ncmpc 0.36 (which was otherwise
    broken in nixpkgs at version 0.35, cf.
    #73000 (comment) )
Things done

Sandboxing was enabled during builds.

  • Built on platform(s)
    • [×] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

On my workstation (nixos 19.09) the tests fail with this output:

client# mpd error: Network is unreachable
client: exit status 1
client: output:
(217.64 seconds)
error: command `/nix/store/dc5xpr79li9gr0bayys0avvwzwd694j2-mpc-0.28/bin/mpc --wait -h serverALSA status' did not succeed (exit code 1)
(848.83 seconds)
command `/nix/store/dc5xpr79li9gr0bayys0avvwzwd694j2-mpc-0.28/bin/mpc --wait -h serverALSA status' did not succeed (exit code 1)

No results/log.html is generated. Obviously an error, but
the test fails just the same when I revert the commit.

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • [×] Tested execution of all binary files (usually in ./result/bin/)

  • [×] Determined the impact on package closure size (by running nix path-info -S before and after)

    /nix/store/92awbqvshidddpj4shsbb6xxyykpfygi-mpd-0.20.23 1734392 406571600
    /nix/store/3v2yvfi5zw77kvxa90c9s2y3chx544vk-mpd-0.21.16 1926736 197168440

  • Ensured that relevant documentation is up to date

  • [×] Fits CONTRIBUTING.md.

Notify maintainers

cc @

- Change build system from autotools to meson.
- Update optional dependencies / build flags:
    - new additions remain disabled by default,
    - options unsupported in nixpkgs are explicitly disabled.
- Drop obsolete patch (upstream removed the offending
  include in ce49d99c2f).
@phi-gamma phi-gamma mentioned this pull request Nov 9, 2019
0 of 10 tasks complete
@ofborg ofborg bot requested review from ehmry, astsmtl, Fuuzetsu and fpletz Nov 9, 2019
@doronbehar

This comment has been minimized.

Copy link
Contributor

doronbehar commented Nov 9, 2019

Gee, there are too many of these! See #57608 and #62771

I'm cc'ing everyone involved everywhere because this is pretty annoying non of these PRs were merged:

@tobim @immae @Ekleog @aanderse @Fuuzetsu @pstch @ryantm @FRidh @timokau @peterhoeg @Mic92.

I hope some of you with merge rights will take the wheel.

I've already said back in #57608 (comment) that it was completely fine and that it can be merged.

@Ekleog

This comment has been minimized.

Copy link
Member

Ekleog commented Nov 9, 2019

@doronbehar With other committers far more knowledgeable than me about mpd already involved in the discussions, I'd rather not be the one to make the final decision of merging one of those PRs. Sorry for the delay! Large rewrites or changes take longer to merge, as fewer people feel qualified to review them.

That said, for now this specific PR appears to not build on ofborg, so I don't think someone will merge it in this state of affairs. The ofborg build logs includes the following, which I guess is the source of the issue.

meson.build:184: WARNING: Your Boost version 1.67 is known to be buggy, and the MPD build will fail. Please upgrade to Boost 1.68 or later.

@phi-gamma

This comment has been minimized.

Copy link
Contributor Author

phi-gamma commented Nov 9, 2019

Closing this in favor of #57608

@phi-gamma phi-gamma closed this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.