Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
nixos/httpd: support overridable virtual hosts #73113
I have split this PR into multiple commits to make it easier to review. Ignoring white space also helps in a few places. Before merging all commits should be squashed as the commits individually break various things.
Motivation for this change
Things not yet done
Example of current test configuration:
This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
ivan left a comment •
I applied this to nixpkgs master, converted my configuration, and merged my http:// and https:// virtualhosts into a single virtualhost. That broke https:// because I had
which caused Apache to run HTTP without SSL on port 443.
From the implementation in nginx, I correctly guessed that I could do this here too:
ivan left a comment
Migrating my configuration wasn't very painful and the migrated configuration appears to behave correctly.
I think this should be merged once someone else looks over it, or confirms that those six Apache-using modules in nixpkgs still work.