Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.typescript-language-server: add typescript dependency #73119

Open
wants to merge 1 commit into
base: master
from

Conversation

@MetaDark
Copy link
Contributor

MetaDark commented Nov 9, 2019

Motivation for this change

typescript-language-server is a wrapper around tsserver and is useless without it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @malob

typescript-language-server is a wrapper around tsserver and is useless
without it
@malob

This comment has been minimized.

Copy link
Contributor

malob commented Nov 29, 2019

This looks good to me! (Works on my macOS machine.)

Copy link
Member

jD91mZM2 left a comment

I stumbled upon this after wondering why typescript-language-server didn't work like it should. Adding typescript as an installed package worked too - although this is obviously a much better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.