Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.measurement: now python3 only #73122

Merged
merged 1 commit into from Jan 11, 2020
Merged

Conversation

@bhipple
Copy link
Contributor

@bhipple bhipple commented Nov 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bhipple bhipple requested review from FRidh and jonringer as code owners Nov 9, 2019
@bhipple
Copy link
Contributor Author

@bhipple bhipple commented Nov 9, 2019

@GrahamcOfBorg build python3Packages.measurement python3Packages.myfitnesspal

@bhipple bhipple force-pushed the bhipple:u/myfitnesspal branch from 439fcfd to 400626d Nov 29, 2019
@bhipple
Copy link
Contributor Author

@bhipple bhipple commented Nov 29, 2019

Implemented all code review suggestions; looks better now, thanks for the advice 👍

@bhipple bhipple force-pushed the bhipple:u/myfitnesspal branch from 400626d to 912bd13 Nov 30, 2019
@bhipple
Copy link
Contributor Author

@bhipple bhipple commented Dec 27, 2019

CC @jonringer mind giving this one another look? I've implemented all of your code review suggestions from the last round.

@bhipple bhipple force-pushed the bhipple:u/myfitnesspal branch from 18437cf to 39dd646 Dec 27, 2019
@bhipple bhipple changed the title pythonPackages.measurement: 2.0.1 -> 3.0.0; pythonPackages.myfitnesspal: 1.13.3 -> 1.13.4 pythonPackages.measurement: 2.0.1 -> 3.0.0 Dec 27, 2019
@bhipple
Copy link
Contributor Author

@bhipple bhipple commented Dec 27, 2019

Updated the title, as @FRidh has already batched the myfitnesspal upgrade in a python bump, so this now only contains the measurement changes.

@bhipple bhipple force-pushed the bhipple:u/myfitnesspal branch from 39dd646 to 627fd1c Dec 27, 2019
@bhipple bhipple force-pushed the bhipple:u/myfitnesspal branch from 627fd1c to a974ce1 Jan 8, 2020
@bhipple bhipple changed the title pythonPackages.measurement: 2.0.1 -> 3.0.0 pythonPackages.measurement: now python3 only Jan 8, 2020
@bhipple
Copy link
Contributor Author

@bhipple bhipple commented Jan 8, 2020

Looks like @FRidh has handled the major version bump in #76059. However, there are still some things for this PR to do, namely:

  1. Switch from pypi to github so that we can run the test cases
  2. Drop python2 (running the tests shows that, indeed, this does not work on python2)
  3. Update the build dependencies to match upstream's changes in the 3.X version
@bhipple
Copy link
Contributor Author

@bhipple bhipple commented Jan 8, 2020

@GrahamcOfBorg build python3Packages.measurement

1 similar comment
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 8, 2020

@GrahamcOfBorg build python3Packages.measurement

Upstream has dropped python2 support and updated their build dependencies as of
the 3.0 version; see here for changelog:
https://github.com/coddingtonbear/python-measurement/releases

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@bhipple bhipple force-pushed the bhipple:u/myfitnesspal branch from a974ce1 to d1ffafc Jan 11, 2020
@bhipple
Copy link
Contributor Author

@bhipple bhipple commented Jan 11, 2020

This package is currently failing on master in all variants:
https://hydra.nixos.org/eval/1564628?filter=measurement&compare=1564607&full=

On py2, it's failing because upstream no longer supports py2. On py3, it's failing because it's missing the patch on the use_scm_version stuff, and if that's fixed it'll fail on missing the sphinx build input and trying to download it. I've rebased this PR and confirmed it fixes all issues, though if there are better ways to do so please let me know.

@GrahamcOfBorg build python3Packages.measurement

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

[6 built, 25 copied (45.3 MiB), 7.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73122
4 package built:
python37Packages.measurement python37Packages.myfitnesspal python38Packages.measurement python38Packages.myfitnesspal
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 11, 2020

@GrahamcOfBorg build python37Packages.measurement python37Packages.myfitnesspal python38Packages.measurement python38Packages.myfitnesspal

@jonringer jonringer merged commit eed30df into NixOS:master Jan 11, 2020
17 of 18 checks passed
17 of 18 checks passed
python37Packages.measurement, python37Packages.myfitnesspal, python38Packages.measurement, python38Packages.myfitnesspal on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.measurement, python37Packages.myfitnesspal, python38Packages.measurement, python38Packages.myfitnesspal on aarch64-linux Success
Details
python37Packages.measurement, python37Packages.myfitnesspal, python38Packages.measurement, python38Packages.myfitnesspal on x86_64-darwin Success
Details
python3Packages.measurement on aarch64-linux Success
Details
python3Packages.measurement on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.