Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero: 0.14.1.0 -> 0.15.0.0 #73124

Closed
wants to merge 1 commit into from
Closed

monero: 0.14.1.0 -> 0.15.0.0 #73124

wants to merge 1 commit into from

Conversation

@prusnak
Copy link
Member

prusnak commented Nov 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ehmry @rnhmjoj

@prusnak prusnak force-pushed the prusnak:monero branch from 81592ff to 2a0c40d Nov 9, 2019
@ofborg ofborg bot requested review from rnhmjoj and ehmry Nov 9, 2019
@prusnak prusnak force-pushed the prusnak:monero branch from 2a0c40d to dcd9921 Nov 9, 2019
@prusnak

This comment has been minimized.

Copy link
Member Author

prusnak commented Nov 9, 2019

@GrahamcOfBorg build monero

@rnhmjoj

This comment has been minimized.

Copy link
Contributor

rnhmjoj commented Nov 10, 2019

Ok, monero looks all right but the GUI didn't build though. I'd rather update both package at the same time to avoid breaking monero-gui

@rnhmjoj rnhmjoj mentioned this pull request Nov 10, 2019
6 of 10 tasks complete
@ehmry
ehmry approved these changes Nov 10, 2019
@ehmry

This comment has been minimized.

Copy link
Member

ehmry commented Nov 10, 2019

Merged at 84c44d8.

@ehmry ehmry closed this Nov 10, 2019
@prusnak prusnak deleted the prusnak:monero branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.