Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.datasette: 0.29.3 -> 0.30.2 #73127

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@jonringer
Copy link
Contributor

jonringer commented Nov 9, 2019

Motivation for this change

noticed it was broken when reviewing #73053

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

python38 broken by python38Packages.websockets:

[0 built (3 failed), 1 copied (0.5 MiB), 0.1 MiB DL]
error: build of '/nix/store/i5isg1kam2ggc0psa769krvp2j4bnd9c-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73127
1 package failed to build:
python38Packages.datasette

1 package were build:
datasette
@jonringer jonringer requested a review from FRidh as a code owner Nov 9, 2019
@ofborg ofborg bot added the 6.topic: python label Nov 9, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 9, 2019

@GrahamcOfBorg build python3Packages.datasette

@jonringer jonringer force-pushed the jonringer:bump-datasette branch from 0337cb0 to e84ed73 Nov 9, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 9, 2019

@GrahamcOfBorg build python3Packages.datasette

pushed darwin fix

@jonringer jonringer mentioned this pull request Nov 9, 2019
4 of 10 tasks complete
@ofborg ofborg bot requested a review from costrouc Nov 9, 2019
@jonringer jonringer changed the title python3Packages.datasett: 0.29.3 -> 0.30.2 python3Packages.datasette: 0.29.3 -> 0.30.2 Nov 9, 2019
@jonringer jonringer force-pushed the jonringer:bump-datasette branch from e84ed73 to d50208f Nov 9, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 9, 2019

fixed commit message

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 11, 2019

@GrahamcOfBorg build python3Packages.datasette

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 11, 2019

darwin failure related to black package

@jonringer jonringer merged commit e9453fc into NixOS:master Nov 11, 2019
16 checks passed
16 checks passed
python3Packages.datasette on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.datasette on aarch64-linux Success
Details
python3Packages.datasette on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.