Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.websockets: 8.0.2 -> 8.1 #73128

Merged
merged 1 commit into from Nov 11, 2019
Merged

Conversation

@jonringer
Copy link
Contributor

jonringer commented Nov 9, 2019

Motivation for this change

noticed the python38 build was broken when reviewing #73127

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 11, 2019

[16 built (7 failed), 32 copied (73.9 MiB), 15.0 MiB DL]
error: build of '/nix/store/xw7zhw57cq60rwcd2sfbf4d75093fn2a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73128
2 package are marked as broken and were skipped:
python37Packages.discordpy python38Packages.discordpy

12 package failed to build:
datasette python37Packages.fastapi python37Packages.hbmqtt python37Packages.sentry-sdk python38Packages.datasette python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.fastapi python38Packages.hbmqtt python38Packages.sanic python38Packages.starlette python38Packages.uvicorn

15 package were build:
gdbgui grab-site python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.websockets python38Packages.flask-socketio python38Packages.python-engineio python38Packages.python-socketio python38Packages.websockets

failures are broken on master

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 11, 2019

@GrahamcOfBorg build gdbgui grab-site python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.flask-socketio python37Packages.python-engineio python37Packages.python-socketio python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.websockets python38Packages.flask-socketio python38Packages.python-engineio python38Packages.python-socketio python38Packages.websockets

@jonringer jonringer merged commit a0476bb into NixOS:master Nov 11, 2019
15 of 16 checks passed
15 of 16 checks passed
gdbgui, grab-site, python37Packages.entrance, python37Packages.entrance-with-router-features, python37Packages.flask-socketio, python37Packages.python-engineio, python37Packages.python-socketio, python37Packages.sanic, python37Packages.starlette, python37Packages.uvicorn, python37Packages.websockets, python38Packages.flask-socketio, python38Packages.python-engineio, python38Packages.python-socketio, python38Packages.websockets on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
gdbgui, grab-site, python37Packages.entrance, python37Packages.entrance-with-router-features, python37Packages.flask-socketio, python37Packages.python-engineio, python37Packages.python-socketio, python37Packages.sanic, python37Packages.starlette, python37Packages.uvicorn, python37Packages.websockets, python38Packages.flask-socketio, python38Packages.python-engineio, python38Packages.python-socketio, python38Packages.websockets on aarch64-linux Success
Details
gdbgui, grab-site, python37Packages.entrance, python37Packages.entrance-with-router-features, python37Packages.flask-socketio, python37Packages.python-engineio, python37Packages.python-socketio, python37Packages.sanic, python37Packages.starlette, python37Packages.uvicorn, python37Packages.websockets, python38Packages.flask-socketio, python38Packages.python-engineio, python38Packages.python-socketio, python38Packages.websockets on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:bump-websockets branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.