Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests to python #73131

Merged
merged 14 commits into from Nov 22, 2019
Merged

Port tests to python #73131

merged 14 commits into from Nov 22, 2019

Conversation

@1000101
Copy link
Member

1000101 commented Nov 9, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test roundcube
@GrahamcOfBorg test fancontrol
@GrahamcOfBorg test deluge
@GrahamcOfBorg test clickhouse
@GrahamcOfBorg test firewall
@GrahamcOfBorg test fish
@GrahamcOfBorg test fluentd
@GrahamcOfBorg test hibernate
@GrahamcOfBorg test hound
@GrahamcOfBorg test handbrake
@GrahamcOfBorg test icingaweb2
@GrahamcOfBorg test incron
@GrahamcOfBorg test minidlna
@GrahamcOfBorg test jackett
@GrahamcOfBorg test miniflux
@GrahamcOfBorg test haproxy

@blitz

This comment has been minimized.

Copy link
Contributor

blitz commented Nov 11, 2019

This looks like a pretty straight forward and mechanical conversion. I spotted no issues.
@tfc Ping.

@tfc
tfc approved these changes Nov 11, 2019
@@ -21,7 +21,7 @@ import ./make-test-python.nix ({ pkgs, ...} : {
};

testScript = ''
roundcube.start
roundcube.start()

This comment has been minimized.

Copy link
@tfc

tfc Nov 11, 2019

Contributor

oh good catch... 👍

@1000101

This comment has been minimized.

Copy link
Member Author

1000101 commented Nov 18, 2019

Should I drop the tests that are failing on arm or is this good to go?

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Nov 21, 2019

@1000101 did these fail on arm previously, too?

Can you rebase on latest master?

@1000101

This comment has been minimized.

Copy link
Member Author

1000101 commented Nov 22, 2019

@1000101 did these fail on arm previously, too?

Can you rebase on latest master?

Jackett and hibernate have been failing on arm before (source: hydra).

Rebased!

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Nov 22, 2019

@GrahamcOfBorg test roundcube
@GrahamcOfBorg test fancontrol
@GrahamcOfBorg test deluge
@GrahamcOfBorg test clickhouse
@GrahamcOfBorg test firewall
@GrahamcOfBorg test fish
@GrahamcOfBorg test fluentd
@GrahamcOfBorg test hibernate
@GrahamcOfBorg test hound
@GrahamcOfBorg test handbrake
@GrahamcOfBorg test icingaweb2
@GrahamcOfBorg test incron
@GrahamcOfBorg test minidlna
@GrahamcOfBorg test jackett
@GrahamcOfBorg test miniflux
@GrahamcOfBorg test haproxy

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Nov 22, 2019

This is a bit hard to merge, can this be broken down to individual PRs?

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Nov 22, 2019

Ok, it was mostly the roundcube fix already fixed in e292be7. Dropped that commit and rebased on master.

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Nov 22, 2019

Built and succeeded running all updated tests locally (x86_64), merging.

@flokli flokli merged commit c81e4f1 into NixOS:master Nov 22, 2019
2 of 4 checks passed
2 of 4 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@1000101 1000101 deleted the 1000101:port-tests-to-python branch Nov 22, 2019
@1000101

This comment has been minimized.

Copy link
Member Author

1000101 commented Nov 22, 2019

Ok, it was mostly the roundcube fix already fixed in e292be7. Dropped that commit and rebased on master.

Thanks a million!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.