Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.plasma5: port to python #73134

Merged
merged 2 commits into from Nov 25, 2019
Merged

Conversation

@worldofpeace
Copy link
Member

worldofpeace commented Nov 9, 2019

Motivation for this change

#72828

Note, a known issue with this test is the desktop doesn't actually get drawn or the panel before it exits.
This is problematic, and wait_for_window actually doesn't check if it's visible or not, so the desktop being broken visually isn't part of the tests coverage. Not sure if there's an API with plasma to check if everything is initialized and stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Nov 9, 2019

nixos/tests/plasma5.nix Outdated Show resolved Hide resolved
@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Nov 22, 2019

@GrahamcOfBorg test plasma5

worldofpeace referenced this pull request Nov 25, 2019
This was the behaviour in the perl test driver too and a regression.

Also cleaned up unused imports
OCR in this test has been disabled.
@worldofpeace worldofpeace force-pushed the worldofpeace:port-plasma5-test branch from 9e567e1 to 796a92a Nov 25, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Nov 25, 2019

@GrahamcOfBorg test plasma5

@worldofpeace worldofpeace force-pushed the worldofpeace:port-plasma5-test branch from 796a92a to 87f3224 Nov 25, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Nov 25, 2019

Uhh, kernel rebuild. This succeeded for me locally anyways.

@worldofpeace worldofpeace merged commit 1dd140f into NixOS:master Nov 25, 2019
14 checks passed
14 checks passed
tests.plasma5 on aarch64-linux Failure
Details
tests.plasma5 on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace worldofpeace deleted the worldofpeace:port-plasma5-test branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.