Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.pantheon: port to python #73140

Merged
merged 4 commits into from Nov 25, 2019
Merged

Conversation

@worldofpeace
Copy link
Member

worldofpeace commented Nov 9, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace requested review from flokli, jonringer and jtojnar Nov 9, 2019
@worldofpeace
Copy link
Member Author

worldofpeace commented Nov 9, 2019

@jtojnar
jtojnar approved these changes Nov 9, 2019
Copy link
Contributor

jtojnar left a comment

LGTM

@mmahut
Copy link
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test pantheon

@mmahut
Copy link
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test pantheon

(odd timeout on 64).

@flokli
Copy link
Contributor

flokli commented Nov 11, 2019

@worldofpeace I also ran into the same timeouts / 100% cpu usage as described in #73190 (comment).

@worldofpeace
Copy link
Member Author

worldofpeace commented Nov 11, 2019

@flokli Ah, I guess this is a bug... I've been trying to port the DE tests but its been practically impossible to discern whether there's something wrong in my test script with debug logging or trying the same in the driver.

@worldofpeace worldofpeace force-pushed the worldofpeace:port-pantheon-test branch from cee14dc to c16df6b Nov 25, 2019
@worldofpeace
Copy link
Member Author

worldofpeace commented Nov 25, 2019

Ok, now using subtest FTW 🌠.

However can't test on ofborg because it'll just timeout rebuilding the kernel.
So holding off on merging until then. I want to be sure this one doesn't timeout like before as we confirmed that on ofborg.

@jonringer
Copy link
Contributor

jonringer commented Nov 25, 2019

don't forget to squash commits :)

@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

This did succeed on my box:

5 out of 5 tests succeeded
test script finished in 74.98s
@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

@GrahamcOfBorg test pantheon

@flokli flokli merged commit b16ddb9 into NixOS:master Nov 25, 2019
13 of 14 checks passed
13 of 14 checks passed
tests.pantheon on aarch64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.pantheon on x86_64-linux Success
Details
@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

Thanks!

@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

oh sorry, I forgot to do the squash :-/

@worldofpeace worldofpeace deleted the worldofpeace:port-pantheon-test branch Nov 25, 2019
@worldofpeace
Copy link
Member Author

worldofpeace commented Nov 25, 2019

oh sorry, I forgot to do the squash :-/

No problem. I was planning on using the squash merge feature for this.
I'll think of it as an extra few commits for descriptiveness 😄

@worldofpeace
Copy link
Member Author

worldofpeace commented Nov 26, 2019

So this test has timed out on hydra on the OCR step matching the bob user's description

Commented it out in 406efdb.
Hopefully there's no other issues with OCR, it wasn't a problem in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.