Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearchPlugins: add ingest-attachment #73150

Merged

Conversation

@ashkitten
Copy link
Contributor

ashkitten commented Nov 10, 2019

Motivation for this change

needed for using elasticsearch for full text search in nextcloud (https://github.com/nextcloud/fulltextsearch_elasticsearch/wiki). tested it briefly to make sure it works in my use-case.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @offlinehacker

@ashkitten

This comment has been minimized.

Copy link
Contributor Author

ashkitten commented Nov 10, 2019

so, i realized that this fails with error: unsupported version 6.8.3 for plugin ingest-attachment since i rebased it onto master from 19.03... but all of the plugins have the same version for 6.8.3, so they're all broken since 3ab433d. shall i fix them in this pull request?

edit: they're also broken for elasticsearch 7 due to the same version mismatch issue. does nobody use elasticsearch plugins?

@offlinehacker

This comment has been minimized.

Copy link
Contributor

offlinehacker commented Nov 10, 2019

I'm not sure who uses them, I was using them when I was still using es on nixos. Can you please update them, looks like someone forgot to update plugins when updating es? Can you also please add comment to elasticsearch that plugins needs to be updated when updating package?

@ashkitten

This comment has been minimized.

Copy link
Contributor Author

ashkitten commented Nov 10, 2019

no problem. i'll also remove the 5.x versions since elasticsearch 5.x has been removed. also, i noticed that some of the plugins use pkgs.fetchurl instead of fetchurl directly so i'll change those.

@ashkitten

This comment has been minimized.

Copy link
Contributor Author

ashkitten commented Nov 10, 2019

i've pushed some style fixups and stuff as well. if a reviewer wants those split out of this pr i'd be happy to do so.

@offlinehacker

This comment has been minimized.

Copy link
Contributor

offlinehacker commented Nov 11, 2019

looks good to me lgtm

@offlinehacker offlinehacker merged commit 4432135 into NixOS:master Nov 11, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
elasticsearchPlugins.search-guard on aarch64-linux Success
Details
elasticsearchPlugins.search-guard on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@offlinehacker

This comment has been minimized.

Copy link
Contributor

offlinehacker commented Nov 11, 2019

Btw @ashkitten have you tested this with nixos module with latest elasticsearch? Does it work well?

@ashkitten

This comment has been minimized.

Copy link
Contributor Author

ashkitten commented Nov 11, 2019

i've tested it with default elasticsearch and it works for my use case, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.