Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia_x11: 2019-11.1 #73167

Merged
merged 2 commits into from Dec 1, 2019
Merged

nvidia_x11: 2019-11.1 #73167

merged 2 commits into from Dec 1, 2019

Conversation

@eadwu
Copy link
Member

eadwu commented Nov 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eadwu

This comment has been minimized.

Copy link
Member Author

eadwu commented Nov 10, 2019

Reused old url since for some reason some revisions don't exist as tags in the Github repository.

@eadwu eadwu mentioned this pull request Nov 10, 2019
3 of 10 tasks complete
@eadwu eadwu changed the title nvidia_x11: 2019 11.1 nvidia_x11: 2019/11.1 Nov 11, 2019
@eadwu eadwu changed the title nvidia_x11: 2019/11.1 nvidia_x11: 2019-11.1 Nov 11, 2019
@eadwu eadwu force-pushed the eadwu:nvidia_x11/2019-11.1 branch from 6c5ee1f to 0946b9e Nov 23, 2019
@eadwu eadwu force-pushed the eadwu:nvidia_x11/2019-11.1 branch from 0946b9e to d537d60 Nov 24, 2019
@veprbl veprbl mentioned this pull request Nov 24, 2019
2 of 10 tasks complete
@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Nov 24, 2019

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Nov 24, 2019

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Nov 24, 2019

@eadwu I believe the eval error is not spurious. I am not sure where it comes from.

@eadwu

This comment has been minimized.

Copy link
Member Author

eadwu commented Nov 24, 2019

Supposedly it comes from bumblebee.nix and specifically from nvidia_x11.useGLVND though I have no idea how just changing the versions and hashes results in something unrelated popping up.

@baracoder

This comment has been minimized.

Copy link
Contributor

baracoder commented Nov 30, 2019

How can I reproduce the eval check locally?

@7c6f434c

This comment has been minimized.

Copy link
Member

7c6f434c commented Nov 30, 2019

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Nov 30, 2019

You're no longer applying generic in the right place because you rewrote the expression for stable -- hence the null. If you reuse the existing structure, everything evals just fine.

Actually, the issue is the nulling at the top of this package. You'll have to flip your if-then-else, and all is good.

@eadwu eadwu force-pushed the eadwu:nvidia_x11/2019-11.1 branch from d537d60 to b05e2c0 Dec 1, 2019
@veprbl veprbl merged commit 8d17a20 into NixOS:master Dec 1, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.