Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qalculate-gtk: add icon theme #73171

Closed
wants to merge 1 commit into from
Closed

Conversation

@B4dM4n
Copy link
Contributor

B4dM4n commented Nov 10, 2019

Motivation for this change

qalculate-gtk is missing button icons for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" (no dependend pkgs)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (210.1M -> 259.3M)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @gebner

@gebner

This comment has been minimized.

Copy link
Member

gebner commented Nov 10, 2019

What icons are you missing? I don't see any icons in either the nixpkgs version nor in this PR.

@B4dM4n

This comment has been minimized.

Copy link
Contributor Author

B4dM4n commented Nov 10, 2019

qalculate (on unstable) is missing icons for me:
image

After adding the icon theme it looks like this:
image

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Nov 10, 2019

I'm going to quote the nixpkgs manual on icon themes in gtk applications:

https://nixos.org/nixpkgs/manual/#ssec-gnome-packaging
When an application uses icons, an icon theme should be available in XDG_DATA_DIRS. The package for the default, icon-less hicolor-icon-theme contains a setup hook that will pick up icon themes from buildInputs and pass it to our wrapper. Unfortunately, relying on that would mean every user has to download the theme included in the package expression no matter their preference. For that reason, we leave the installation of icon theme on the user. If you use one of the desktop environments, you probably already have an icon theme installed.

So we prefer that we didn't add this icon theme to the package. And instead configure your system to include a icon theme for the application.

@B4dM4n

This comment has been minimized.

Copy link
Contributor Author

B4dM4n commented Nov 11, 2019

I'm going to quote the nixpkgs manual on icon themes in gtk applications:

https://nixos.org/nixpkgs/manual/#ssec-gnome-packaging
When an application uses icons, an icon theme should be available in XDG_DATA_DIRS. The package for the default, icon-less hicolor-icon-theme contains a setup hook that will pick up icon themes from buildInputs and pass it to our wrapper. Unfortunately, relying on that would mean every user has to download the theme included in the package expression no matter their preference. For that reason, we leave the installation of icon theme on the user. If you use one of the desktop environments, you probably already have an icon theme installed.

Thanks for the hint. I was not aware of this section in the manual.

After installing adwaita-icon-theme globally and logging in again, the icons are working fine now.

@B4dM4n B4dM4n closed this Nov 11, 2019
@B4dM4n B4dM4n deleted the B4dM4n:qalculate-gtk-fixes branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.