Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-shell:init at 2015-05-23 #73192

Closed
wants to merge 5 commits into from
Closed

nixos-shell:init at 2015-05-23 #73192

wants to merge 5 commits into from

Conversation

@pasqui23
Copy link
Contributor

pasqui23 commented Nov 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nixos-discourse
Copy link

nixos-discourse commented Dec 2, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/86

@teto
Copy link
Contributor

teto commented Dec 2, 2019

isn't the upstream at https://github.com/Mic92/nixos-shell ?

@pasqui23
Copy link
Contributor Author

pasqui23 commented Dec 3, 2019

You're right,and it's even more recently updated

@pasqui23
Copy link
Contributor Author

pasqui23 commented Dec 3, 2019

That one has the same name but it's different:it spawns a whole new virtual machine instead of just a container

@tomberek
Copy link
Contributor

tomberek commented Dec 8, 2019

nixos-container is required at runtime, but is not in the dependencies nor propagated. And should it be limited to NixOS? or can someone run nixos-container on non-NixOS?

@pasqui23
Copy link
Contributor Author

pasqui23 commented Jan 14, 2020

@tomberek it is merely a thin wrapper aroun nixos-container,so it should run where nixos-container runs

@pasqui23 pasqui23 force-pushed the pasqui23:nosh branch from 010ef7b to b4cc827 Jan 14, 2020
@pasqui23 pasqui23 force-pushed the pasqui23:nosh branch from b4cc827 to ee763ec Jan 15, 2020
@pasqui23
Copy link
Contributor Author

pasqui23 commented Jan 15, 2020

Ok,why the check meta fails?

Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
@doronbehar
Copy link
Contributor

doronbehar commented May 23, 2020

Closed in favor of #85673 .

@doronbehar doronbehar closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.