Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circus: fix incompatible dependency of python-circus #73199

Merged
merged 3 commits into from Nov 11, 2019

Conversation

@tekeri
Copy link
Contributor

tekeri commented Nov 11, 2019

Motivation for this change

Fix runtime failure

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh @volth @etu @xeji

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 11, 2019

In the Python packages set only one version of a package at the time is allowed.

@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 11, 2019

OK, how can I fix this package?

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 11, 2019

Well, aside from introducing tornado 5 compatibility there isn't anything you can do inside python-packages.nix.

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 11, 2019

If it is used only as an application, then it could be moved out of python-packages.nix and python-modules/ and use tornado_4.

@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 11, 2019

It seems the upstream is not willing to introduce tornado 5 compatibility... ( circus-tent/circus#1064 )
As it is an application, moving it out of python packages set should be the way to go.
Thanks!

@@ -1,7 +1,7 @@
{ stdenv, buildPythonPackage, fetchPypi

This comment has been minimized.

Copy link
@FRidh

FRidh Nov 11, 2019

Member

pass in python3 instead of the python packages

This comment has been minimized.

Copy link
@tekeri

tekeri Nov 11, 2019

Author Contributor

trying to fix

This comment has been minimized.

Copy link
@tekeri

tekeri Nov 11, 2019

Author Contributor

you mean add python3Packages to args and use referrence to python3Packages.buildPythonPackage?

This comment has been minimized.

Copy link
@tekeri

tekeri Nov 11, 2019

Author Contributor

maybe done

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@FRidh FRidh merged commit cd41194 into NixOS:master Nov 11, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
circus on aarch64-linux Success
Details
circus on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
juaningan added a commit to juaningan/nixpkgs that referenced this pull request Nov 11, 2019
* circus: fix incompatible dependency of python-circus

* circus: move out of python packages set

* circus: remove directly used python packages arguments
@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 12, 2019

Thanks @FRidh

@tekeri tekeri deleted the tekeri:fix-python-circus-imcompat-tornade branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.