Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.FindLib: init at 1.04 #73202

Merged
merged 1 commit into from Nov 12, 2019
Merged

perlPackages.FindLib: init at 1.04 #73202

merged 1 commit into from Nov 12, 2019

Conversation

@tekeri
Copy link
Contributor

tekeri commented Nov 11, 2019

Motivation for this change

Add a missing perl package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @stigtsp @puckipedia @c0bw3b @FRidh

@tekeri tekeri changed the title perlPackages-Find-Lib: init at 1.04 perlPackages.Find-Lib: init at 1.04 Nov 11, 2019
@stigtsp

This comment has been minimized.

Copy link
Member

stigtsp commented Nov 11, 2019

nix-review pr 73202 returned:

2 package were build:
perl528Packages.FindLib perl530Packages.FindLib
@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 11, 2019

Thanks @stigtsp, I'm learning about nix-review.

@stigtsp

This comment has been minimized.

Copy link
Member

stigtsp commented Nov 11, 2019

Can you amend the previous commit so it's one commit?

@tekeri tekeri force-pushed the tekeri:add-perl-findlib branch from 7e130f6 to 54a4ede Nov 11, 2019
@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 11, 2019

It should be clean now.

@tekeri tekeri changed the title perlPackages.Find-Lib: init at 1.04 perlPackages.FindLib: init at 1.04 Nov 11, 2019
@tekeri tekeri force-pushed the tekeri:add-perl-findlib branch from 54a4ede to c432914 Nov 11, 2019
Copy link
Member

stigtsp left a comment

Looks good to me

@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Nov 12, 2019

@GrahamcOfBorg build perl528Packages.FindLib perl530Packages.FindLib

@c0bw3b c0bw3b merged commit 6b0843d into NixOS:master Nov 12, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
perl528Packages.FindLib, perl530Packages.FindLib on aarch64-linux Success
Details
perl528Packages.FindLib, perl530Packages.FindLib on x86_64-darwin Success
Details
perl528Packages.FindLib, perl530Packages.FindLib on x86_64-linux Success
Details
@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 12, 2019

Thanks @stigtsp, @c0bw3b !

@tekeri tekeri deleted the tekeri:add-perl-findlib branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.