Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.CacheKyotoTycoon: init at 0.16 #73204

Merged
merged 2 commits into from Nov 11, 2019

Conversation

@tekeri
Copy link
Contributor

tekeri commented Nov 11, 2019

Motivation for this change

Add a missing perl package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @puckipedia @stigtsp @7c6f434c

@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 11, 2019

deps #73201

@tekeri tekeri changed the title perlPackages-Cache-KyotoTycoon: init at 0.16 perlPackages.Cache-KyotoTycoon: init at 0.16 Nov 11, 2019
@stigtsp

This comment has been minimized.

Copy link
Member

stigtsp commented Nov 11, 2019

deps #73201

Please include the dependency #73201 in this PR.

@stigtsp stigtsp mentioned this pull request Nov 11, 2019
2 of 10 tasks complete
@tekeri tekeri force-pushed the tekeri:add-perl-cachekyototycoon branch 3 times, most recently from ded08b2 to 738ee41 Nov 11, 2019
@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 11, 2019

squashed

@stigtsp

This comment has been minimized.

Copy link
Member

stigtsp commented Nov 11, 2019

The PR name, and commit message(s), do not match the derivation names. For example: perlPackages.Cache-KyotoTycoon: init at 0.16 should be perlPackages.CacheKyotoTycoon: init at 0.16, and perlPackages-Furl-3.13 should be perlPackages.Furl: init at 3.13.

@tekeri tekeri changed the title perlPackages.Cache-KyotoTycoon: init at 0.16 perlPackages.CacheKyotoTycoon: init at 0.16 Nov 11, 2019
@tekeri tekeri force-pushed the tekeri:add-perl-cachekyototycoon branch from 738ee41 to eb523b8 Nov 11, 2019
@stigtsp

This comment has been minimized.

Copy link
Member

stigtsp commented Nov 11, 2019

Tested Furl with:

nix-shell -p 'perl.withPackages(p: [p.Furl p.IOSocketSSL])' --run "perl -MFurl -e 'print Furl->new->get(qq(https://nixos.org/))->status_line'"
200 OK⏎
@stigtsp

This comment has been minimized.

Copy link
Member

stigtsp commented Nov 11, 2019

Tested CacheKyotoTycoon by loading it only:

nix-shell -p 'perl.withPackages(p: [p.CacheKyotoTycoon])' --run "perl -MCache::KyotoTycoon -le 'print 1'"
1
Copy link
Member

stigtsp left a comment

Looks good to me

@7c6f434c 7c6f434c merged commit 64f146b into NixOS:master Nov 11, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@tekeri

This comment has been minimized.

Copy link
Contributor Author

tekeri commented Nov 12, 2019

Thank you for review and merge @stigtsp, @7c6f434c

@tekeri tekeri deleted the tekeri:add-perl-cachekyototycoon branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.