Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patool: init at 1.12 #73209

Open
wants to merge 1 commit into
base: master
from
Open

patool: init at 1.12 #73209

wants to merge 1 commit into from

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 11, 2019

Motivation for this change

Closes #64778.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @


This change is Reviewable

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
sha256 = "15qhrc2fl82pyp9w5s2s7d5cihm0zi988qpmysyfsfz1pzw0q673";
};

doCheck = false;

This comment has been minimized.

Copy link
@jonringer

jonringer Nov 11, 2019

Contributor

this is a last resort, please check out source if the pypi doesn't have tests in it, and if neither have tests, then please give a comment saying so

This comment has been minimized.

Copy link
@filalex77

filalex77 Nov 25, 2019

Author Contributor

Okay, so patool does have tests, has some really complicated requirements-test.txt, that I was unable to reproduce. Should we skip it for now?

This comment has been minimized.

Copy link
@marius851000

marius851000 Nov 29, 2019

Contributor

Many of those error doesn't seem to be caused by missing package: I think that is rather because there should the tests/data folder, that doesn't (for any reason) doesn't exist. They should be removed when updating to pip, as they are present in the github repo.

Closes #64778.
@filalex77 filalex77 force-pushed the filalex77:patool-1.12 branch from e93b9ea to c94ed8e Nov 25, 2019
@filalex77 filalex77 requested a review from jonringer Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.