Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages."@angular/cli": disable analytics #73225

Open
wants to merge 2 commits into
base: master
from

Conversation

@evanjs
Copy link
Member

evanjs commented Nov 11, 2019

Motivation for this change

@angular/cli fails to build due to the prompt for NG_CLI_ANALYTICS
Here is the relevant portion of analytics-prompt.js.

Set NG_ANALYTICS to false to skip this prompt and allow the build to continue

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
evanjs added 2 commits Nov 11, 2019
@angular/cli fails to build due to the prompt for NG_CLI_ANALYTICS

Set NG_CLI_ANALYTICS to false to skip this prompt and allow the build to
continue
@evanjs

This comment has been minimized.

Copy link
Member Author

evanjs commented Nov 17, 2019

So this is sort of odd...
I just came across this commit, which said it fixed this sort of issue before.

I wonder why it suddenly stopped working; maybe addressing that issue might be a better idea?

evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.