Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages."@angular/cli": disable analytics #73225

Merged
merged 2 commits into from Feb 10, 2020

Conversation

@evanjs
Copy link
Member

@evanjs evanjs commented Nov 11, 2019

Motivation for this change

@angular/cli fails to build due to the prompt for NG_CLI_ANALYTICS
Here is the relevant portion of analytics-prompt.js.

Set NG_ANALYTICS to false to skip this prompt and allow the build to continue

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@evanjs
Copy link
Member Author

@evanjs evanjs commented Nov 17, 2019

So this is sort of odd...
I just came across this commit, which said it fixed this sort of issue before.

I wonder why it suddenly stopped working; maybe addressing that issue might be a better idea?

evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Dec 7, 2019
@evanjs evanjs mentioned this pull request Feb 7, 2020
0 of 10 tasks complete
@evanjs evanjs requested review from adisbladis and Mic92 Feb 9, 2020
evanjs added 2 commits Feb 10, 2020
@angular/cli fails to build due to the prompt for NG_CLI_ANALYTICS

Set NG_CLI_ANALYTICS to false to skip this prompt and allow the build to
continue
@evanjs evanjs force-pushed the evanjs:disable-angular_cli-analytics branch from 436d20f to a68edf4 Feb 10, 2020
@Mic92 Mic92 merged commit 21e1500 into NixOS:master Feb 10, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@evanjs evanjs deleted the evanjs:disable-angular_cli-analytics branch Feb 11, 2020
evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.