Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkl: add scalapack libraries to output #73227

Merged
merged 1 commit into from Nov 18, 2019
Merged

Conversation

@markuskowa
Copy link
Member

markuskowa commented Nov 11, 2019

Motivation for this change

Add the scalapack extensions to the output.

Things done

Tested compilation with an external program (bagel quantum chemistry). Seems to work fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bhipple

Copy link
Contributor

smaret left a comment

On Darwin we unpack and install all the libraries from the MKL. Perhaps we should do the same for NixOS/Linux?

@markuskowa

This comment has been minimized.

Copy link
Member Author

markuskowa commented Nov 17, 2019

@smaret Not sure it would make sense to unpack all RPMs. There is a lot of stuff that is distributed of a bunch directories that may not be required. @bhipple may be able to give more insight here.

Copy link
Contributor

bhipple left a comment

I think having a whitelist of RPMs to include -- as we're currently doing -- is preferable to including everything. It's relatively easy to add more if people need it, and there are many packages unlikely to be used.

I might :sort the list though.

@markuskowa markuskowa force-pushed the markuskowa:fix-mkl branch from 3cf4495 to d817a49 Nov 18, 2019
@ofborg ofborg bot requested a review from bhipple Nov 18, 2019
@markuskowa markuskowa merged commit 7d728fa into NixOS:master Nov 18, 2019
16 checks passed
16 checks passed
mkl on aarch64-linux No attempt
Details
mkl on x86_64-darwin No attempt
Details
mkl on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@markuskowa markuskowa deleted the markuskowa:fix-mkl branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.