Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-deb: init at 1.21.1 #73230

Merged
merged 1 commit into from Nov 13, 2019
Merged

cargo-deb: init at 1.21.1 #73230

merged 1 commit into from Nov 13, 2019

Conversation

@filalex77
Copy link
Contributor

filalex77 commented Nov 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@filalex77 filalex77 requested a review from JohnAZoidberg Nov 12, 2019
Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
executable seems to work

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73230
1 package were build:
cargo-deb
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 13, 2019

can you squash the commits?

git reset HEAD^
git add pkgs/
git commit --amend --no-edit
git push --force <fork> <branch>
Co-Authored-By: Daniel Schaefer <git@danielschaefer.me>
@filalex77 filalex77 force-pushed the filalex77:cargo-deb-1.21.1 branch from ac376c1 to c154d4d Nov 13, 2019
@filalex77 filalex77 requested a review from jonringer Nov 13, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 13, 2019

@GrahamcOfBorg build cargo-deb

@jonringer jonringer merged commit 20394a3 into NixOS:master Nov 13, 2019
15 of 16 checks passed
15 of 16 checks passed
cargo-deb on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
cargo-deb on aarch64-linux Success
Details
cargo-deb on x86_64-darwin Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@filalex77 filalex77 deleted the filalex77:cargo-deb-1.21.1 branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.