Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles/graphical.nix: Drop systemWide pulseaudio in iso #73232

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@etu
Copy link
Contributor

etu commented Nov 11, 2019

Motivation for this change

It's not needed since #66338 and should have been done earlier.

This is based on a follow-up on #56167.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

It's not needed since #66338 and should have been done earlier.

This is based on a follow-up on #56167.
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Nov 11, 2019

Did the users of graphical.nix ever use a root user?
It appears Demo user account is what's used in demo.nix, so I'm not sure this was ever needed.

Copy link
Member

worldofpeace left a comment

LGTM, no testing done but I believe it was unneeded anyway. We could probably backport it even.

@etu

This comment has been minimized.

Copy link
Contributor Author

etu commented Nov 12, 2019

@worldofpeace

Did the users of graphical.nix ever use a root user?

Yes it did. That's why I added that line. I tested it myself both before and after adding the line on actual hardware.

It appears Demo user account is what's used in demo.nix, so I'm not sure this was ever needed.

I'm not sure what demo.nix is for...

@etu etu requested a review from adisbladis Nov 12, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Nov 12, 2019

@etu I believe it's for the ova. We have this annoying inconsistency with the ISO's and the OVA.
Even worse is we've documented and exposed them https://nixos.org/nixos/manual/index.html#sec-profile-demo, https://nixos.org/nixos/manual/index.html#sec-profile-graphical. I really hope no one was using this.

@adisbladis adisbladis merged commit cc56226 into NixOS:master Nov 12, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@etu etu deleted the etu:disable-systemwide-pulse-iso branch Nov 12, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Nov 12, 2019

#66338 is in 19.09 so I think we should backport this.

@etu

This comment has been minimized.

Copy link
Contributor Author

etu commented Nov 12, 2019

@worldofpeace Yeah, we should. I'll look into it later today unless someone does it before me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.