Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.09] libxslt: add patch for CVE-2019-18197 #73245

Merged

Conversation

@risicle
Copy link
Contributor

risicle commented Nov 11, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-18197

See #73178 for master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle

This comment has been minimized.

Copy link
Contributor Author

risicle commented Nov 11, 2019

@GrahamcOfBorg build libxml2 libxslt xmlstarlet python37Packages.lxml

@risicle risicle changed the title libxslt: add patch for CVE-2019-18197 [r19.09] libxslt: add patch for CVE-2019-18197 Nov 11, 2019
@ofborg ofborg bot requested a review from edolstra Nov 11, 2019
@veprbl veprbl added this to WIP in Staging via automation Nov 11, 2019
@veprbl veprbl moved this from WIP to Needs review in Staging Nov 11, 2019
@veprbl veprbl removed this from Needs review in Staging Nov 11, 2019
@veprbl veprbl added this to Ready in Staging (stable) Nov 11, 2019
@veprbl veprbl moved this from Ready to Needs review in Staging (stable) Nov 11, 2019
@flokli
flokli approved these changes Nov 13, 2019
Staging (stable) automation moved this from Needs review to Ready Nov 13, 2019
@flokli flokli merged commit bf802b9 into NixOS:staging-19.09 Nov 13, 2019
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libxml2, libxslt, python37Packages.lxml, xmlstarlet on aarch64-linux Success
Details
libxml2, libxslt, python37Packages.lxml, xmlstarlet on x86_64-linux Success
Details
libxslt on aarch64-linux Success
Details
libxslt on x86_64-linux Success
Details
Staging (stable) automation moved this from Ready to Done Nov 13, 2019
@vcunat vcunat mentioned this pull request Dec 29, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.