Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.uvloop: 0.13.0 -> 0.14.0 #73247

Merged
merged 2 commits into from Nov 12, 2019
Merged

Conversation

@jonringer
Copy link
Contributor

jonringer commented Nov 11, 2019

Motivation for this change

noticed the python38 build was broken, this appears to fix it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner Nov 11, 2019
@ofborg ofborg bot added the 6.topic: python label Nov 11, 2019
@ofborg ofborg bot requested a review from costrouc Nov 11, 2019
jonringer added 2 commits Nov 11, 2019
@jonringer jonringer force-pushed the jonringer:bump-uvloop branch from 2f8cdc9 to 27b9bec Nov 11, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 11, 2019

bumped uvicorn because it was also broken for python38

@ofborg ofborg bot requested a review from wd15 Nov 11, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 12, 2019

failures are broken on master

[10 built (5 failed), 0.0 MiB DL]
error: build of '/nix/store/4jy9zgrp406bvr5d5rv4pq27hnf11drx-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73247
5 package failed to build:
python37Packages.fastapi python37Packages.sentry-sdk python38Packages.asyncpg python38Packages.datasette python38Packages.fastapi

16 package were build:
datasette mtprotoproxy python37Packages.asyncpg python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.sanic python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 12, 2019

@GrahamcOfBorg build datasette mtprotoproxy python37Packages.asyncpg python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.sanic python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht

1 similar comment
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 12, 2019

@GrahamcOfBorg build datasette mtprotoproxy python37Packages.asyncpg python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.sanic python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht

@Mic92
Mic92 approved these changes Nov 12, 2019
@Mic92
Mic92 approved these changes Nov 12, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 12, 2019

I can't see any regressions, that didn't exist before, mreging

@jonringer jonringer merged commit 98912d2 into NixOS:master Nov 12, 2019
16 checks passed
16 checks passed
datasette, mtprotoproxy, python37Packages.asyncpg, python37Packages.entrance, python37Packages.entrance-with-router-features, python37Packages.sanic, python37Packages.starlette, python37Packages.uvicorn, python37Packages.uvloop, python38Packages.entrance, python38Packages.entrance-with-router-features, python38Packages.sanic, python38Packages.starlette, python38Packages.uvicorn, python38Packages.uvloop, sourcehut.listssrht on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
datasette, mtprotoproxy, python37Packages.asyncpg, python37Packages.entrance, python37Packages.entrance-with-router-features, python37Packages.sanic, python37Packages.starlette, python37Packages.uvicorn, python37Packages.uvloop, python38Packages.entrance, python38Packages.entrance-with-router-features, python38Packages.sanic, python38Packages.starlette, python38Packages.uvicorn, python38Packages.uvloop, sourcehut.listssrht on aarch64-linux Success
Details
datasette, mtprotoproxy, python37Packages.asyncpg, python37Packages.entrance, python37Packages.entrance-with-router-features, python37Packages.sanic, python37Packages.starlette, python37Packages.uvicorn, python37Packages.uvloop, python38Packages.entrance, python38Packages.entrance-with-router-features, python38Packages.sanic, python38Packages.starlette, python38Packages.uvicorn, python38Packages.uvloop, sourcehut.listssrht on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.