Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guake: add missing dependency on setuptools #73250

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@wamserma
Copy link
Contributor

wamserma commented Nov 11, 2019

Motivation for this change

guake crashed at launch due to missing dependency:

  File "/nix/store/3pwkg13xs7brvhfm3xwnkj2ygfi5lfsg-guake-3.6.3/lib/python3.7/site-packages/guake/paths.py", line 26, in <module>
    from pkg_resources import Requirement
ModuleNotFoundError: No module named 'pkg_resources'

The missing module is provided by setuptools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @msteen

python setuptools is a runtime dependency (as
from pkg_resources import Requirement
is used)
@jtojnar jtojnar merged commit 54b2edf into NixOS:master Nov 11, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
guake on aarch64-linux Success
Details
guake on x86_64-linux Success
Details
@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Nov 11, 2019

Thanks.

wamserma added a commit to wamserma/nixpkgs that referenced this pull request Nov 12, 2019
guake: add missing dependency on setuptools
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Jan 19, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/guake-failed-to-load-module-unity-gtk-module/5556/2

@wamserma wamserma deleted the wamserma:guake-add-setuptools branch Jan 19, 2020
jtojnar added a commit that referenced this pull request Jan 19, 2020
Merge pull request #73250 from wamserma/guake-add-setuptools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.