Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediathekview: 13.2.1 -> 13.5.0 #73255

Merged
merged 1 commit into from Nov 20, 2019
Merged

Conversation

@Moredread
Copy link
Contributor

Moredread commented Nov 11, 2019

Motivation for this change

Version bump.

It now works with OpenJDK again! :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Moredread

This comment has been minimized.

Copy link
Contributor Author

Moredread commented Nov 11, 2019

/nix/store/kld93k891myscac7dwhbzmk7shvp5dgl-mediathekview-13.2.1	  465469184
/nix/store/wx089v8nbw8jw4qpz2j9qx1ncbl33aql-mediathekview-13.5.0	 1171387872

I guess that is due to the switch to OpenJDK, the derivation itself is only 64M, OpenJDK is about 1.1 GB.

Copy link
Contributor

Lassulus left a comment

tested with nix-review, had to set my wmname to LG3D (with wmname LG3D) then it started and I had to provide paths to vlc and ffmpeg. afterwards I could successfully watch something

@Moredread

This comment has been minimized.

Copy link
Contributor Author

Moredread commented Nov 20, 2019

@Lassulus Sadly this is how it worked before. I'm not sure we can set the paths from outside the application.

@Lassulus Lassulus merged commit 3945c1d into NixOS:master Nov 20, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mediathekview on aarch64-linux Success
Details
mediathekview on x86_64-linux Success
Details
@Moredread Moredread deleted the Moredread:mediathekview-13.5 branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.