Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yabai: init at 2.1.2 #73260

Closed
wants to merge 2 commits into from
Closed

yabai: init at 2.1.2 #73260

wants to merge 2 commits into from

Conversation

@jacereda
Copy link
Contributor

jacereda commented Nov 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

meta = with stdenv.lib; {
description = "A tiling window manager for macOS based on binary space partitioning";
homepage = https://github.com/koekeishiya/yabai;
platforms = platforms.darwin;

This comment has been minimized.

Copy link
@Lassulus

Lassulus Nov 17, 2019

Contributor

a maintainer would be cool

pkgs/os-specific/darwin/yabai/default.nix Outdated Show resolved Hide resolved
Co-Authored-By: Ryan Mulligan <ryan@ryantm.com>
@bkase
Copy link
Contributor

bkase commented Dec 16, 2019

@ryantm is this ready to go now?

@Lassulus
Copy link
Contributor

Lassulus commented Dec 18, 2019

Merging without a maintainer is not preferred. Since there is no one who will update it or can be pinged for reviews.

@jacereda
Copy link
Contributor Author

jacereda commented Dec 18, 2019

I'm seriously considering switching to Linux in the not too distant future, so I'm not a good candidate for maintaining this.

@cmacrae
Copy link
Contributor

cmacrae commented Apr 30, 2020

@ryantm @Lassulus

🖐️ I've been maintaining my own package for yabai for a few months and came here looking to see if anyone else had submitted a PR before I did.

I'll happily volunteer as a maintainer. I can submit a new PR with a more recent build and other minor improvements to supersede this PR, if that would be the favoured approach? :)

@Lassulus
Copy link
Contributor

Lassulus commented Apr 30, 2020

@cmacrae sounds like a good idea 👍

@cmacrae cmacrae mentioned this pull request Apr 30, 2020
3 of 10 tasks complete
@cmacrae
Copy link
Contributor

cmacrae commented May 1, 2020

@ryantm @Lassulus I opened this yesterday ☝🏻😊

@LnL7 LnL7 closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.