Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
libredirect: fix argument forwarding in `open*` functions #73266
Motivation for this change
This PR solves this issue: #73077 .
Flag `O_TMPFILE` was added in Linux 3.11. It affects whether or not `mode` argument should be passed.
@jtojnar I'm not sure if I can write a good test that tests that
So either there is a guarantee that during test a file within supported filesystem can be created, or we test only if we can and silently fail if unsupported filesystem is used. In the later case I wonder if that counts as breaking reproducibility.
jonringer left a comment •
didn't do any testing
jonringer left a comment