Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] steam: Add libva to chrootenv #73281

Merged
merged 1 commit into from Nov 12, 2019
Merged

Conversation

@baldo
Copy link
Contributor

baldo commented Nov 12, 2019

Motivation for this change

This is a backport of #73108 to 19.09:

After the newest update Steam itself complained about missing files
and would not start:

  • libva.so.2
  • libva-x11.so.2
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aanderse

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Nov 12, 2019

Please use git cherry-pick -x on the commit from master.

After the newest update Steam itself complained about missing files
and would not start:

* libva.so.2
* libva-x11.so.2

(cherry picked from commit 5a13b85)
@baldo baldo force-pushed the baldo:steam branch from bfe079d to 4d114d2 Nov 12, 2019
@baldo

This comment has been minimized.

Copy link
Contributor Author

baldo commented Nov 12, 2019

@worldofpeace Done. Wasn't aware of that flag. Thanks for the pointer. :)

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Nov 12, 2019

@worldofpeace Done. Wasn't aware of that flag. Thanks for the pointer. :)

Yep, we actually have it in the docs https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches.

@worldofpeace worldofpeace changed the title backport: steam: Add libva to chrootenv. [19.09] steam: Add libva to chrootenv Nov 12, 2019
@worldofpeace worldofpeace merged commit 975ad80 into NixOS:release-19.09 Nov 12, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Checking new out paths
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.