Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash: 1.0.13 -> 2.1.0-1 #73353

Merged
merged 1 commit into from Nov 25, 2019
Merged

zcash: 1.0.13 -> 2.1.0-1 #73353

merged 1 commit into from Nov 25, 2019

Conversation

@tkerber
Copy link
Member

tkerber commented Nov 13, 2019

Motivation for this change

Zcash is severely outdated, and is incompatible with the live network.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Ensured that relevant documentation is up to date
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rht


installPhase = ''
mkdir -p $out/lib
cp target/release/librustzcash.a $out/lib/
mkdir -p $out/include
cp include/librustzcash.h $out/include/
cp librustzcash/include/librustzcash.h $out/include/

This comment has been minimized.

@rht

rht Nov 13, 2019 Member

Was there an update in how librustzcash was fetched from github?

This comment has been minimized.

@tkerber

tkerber Nov 13, 2019 Author Member

No, it now has multiple sub-projects, the main one of which is in the directory librustzcash.

This comment has been minimized.

@rht

rht Nov 13, 2019 Member

OK I see.

'';

doCheck = false;

This comment has been minimized.

@rht

rht Nov 13, 2019 Member

This line is unused.

This comment has been minimized.

@tkerber

tkerber Nov 13, 2019 Author Member

It is not. I should have added a comment in hindsight. Without this line, it runs cargo test in their rust workspace. These appear quite substantial (and single threaded) - I left them running for the best part of yesterday on my pc before giving up and going to bed, hence why I felt it best to disable them.

This comment has been minimized.

@rht

rht Nov 13, 2019 Member

Make sense.

@rht
Copy link
Member

rht commented Nov 13, 2019

This patch LGTM.

@tkerber tkerber force-pushed the tkerber:zcash-2.1.0-1 branch from e8a5012 to cc1568d Nov 13, 2019
@tkerber
Copy link
Member Author

tkerber commented Nov 13, 2019

Minor delta: I removed the dependency on libsnark, which appears to not be needed any longer, and is blocking the aarch64 build.

Copy link
Contributor

Lassulus left a comment

tested with nix-review

@Lassulus Lassulus merged commit 4f3e74a into NixOS:master Nov 25, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zcash on aarch64-linux Success
Details
zcash on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.