Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.03] samba: add patches for CVE-2019-3880, CVE-2019-10218, CVE-2019-14833 & CVE-2019-14847 #73370

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@risicle
Copy link
Contributor

risicle commented Nov 13, 2019

using patches from the 4.9 branch, but luckily these all apply and work
against 4.7

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-10218
https://nvd.nist.gov/vuln/detail/CVE-2019-14833
https://nvd.nist.gov/vuln/detail/CVE-2019-14847

Using patches from the 4.9 branch, but luckily these all apply and work against 4.7

python27Packages.cherrypy is broken on 19.03, preventing a samba4Full build. I think I know how to fix that though (I'll do it separately)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle

This comment has been minimized.

Copy link
Contributor Author

risicle commented Nov 14, 2019

@GrahamcOfBorg test samba
@GrahamcOfBorg build samba gvfs

…& CVE-2019-14847

using patches from the 4.8 & 4.9 branches, but luckily these all apply and
work against 4.7
@risicle risicle force-pushed the risicle:ris-samba-CVEs-r19.03 branch from 034be5b to b85424a Nov 15, 2019
@risicle risicle changed the title [r19.03] samba: add patches for CVE-2019-10218, CVE-2019-14833 & CVE-2019-14847 [r19.03] samba: add patches for CVE-2019-3880, CVE-2019-10218, CVE-2019-14833 & CVE-2019-14847 Nov 15, 2019
@risicle

This comment has been minimized.

Copy link
Contributor Author

risicle commented Nov 16, 2019

@d-goldin d-goldin mentioned this pull request Nov 19, 2019
4 of 10 tasks complete
@d-goldin

This comment has been minimized.

Copy link
Contributor

d-goldin commented Nov 19, 2019

Sorry for the noise, I misread 19.03 as 19.09, so this one should still remain valid.

@ckauhaus ckauhaus merged commit 6d448d7 into NixOS:release-19.03 Nov 19, 2019
19 checks passed
19 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
gvfs, samba on aarch64-linux Success
Details
gvfs, samba on x86_64-linux Success
Details
samba on aarch64-linux Success
Details
samba on x86_64-linux Success
Details
tests.samba on aarch64-linux Success
Details
tests.samba on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.