Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elogind: 239.5 -> 241.3 #73376

Merged
merged 1 commit into from Nov 20, 2019
Merged

elogind: 239.5 -> 241.3 #73376

merged 1 commit into from Nov 20, 2019

Conversation

@nh2
Copy link
Contributor

nh2 commented Nov 14, 2019

Motivation for this change

Changelog: https://github.com/elogind/elogind/releases/tag/v241.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

myself

@nh2

This comment has been minimized.

Copy link
Contributor Author

nh2 commented Nov 14, 2019

@nh2

This comment has been minimized.

Copy link
Contributor Author

nh2 commented Nov 14, 2019

Why does ofborg say this rebuilds >= 11 packages on Darwin?

This even has platforms = platforms.linux.

@nh2

This comment has been minimized.

Copy link
Contributor Author

nh2 commented Nov 14, 2019

Why does ofborg say this rebuilds >= 11 packages on Darwin?

Uh looks like the dep is pulled in for polkit on Darwin. Probably want to make that optional.

My fault in commit 1ca49b8 / PR #72057.

@nh2 nh2 mentioned this pull request Nov 14, 2019
4 of 10 tasks complete
@nh2 nh2 merged commit b679ce8 into NixOS:master Nov 20, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
elogind on aarch64-linux Success
Details
elogind on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@nh2

This comment has been minimized.

Copy link
Contributor Author

nh2 commented Nov 20, 2019

My fault in commit 1ca49b8 / PR #72057.

Fixing in #73837.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.