Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildGoPackage: disable go module #73380

Merged
merged 2 commits into from Dec 10, 2019
Merged

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Nov 14, 2019

Motivation for this change

Go 1.13 slightly changed the behavior GO111MODULE=auto [1], which might
accidentally cause the go command to build the module, for instance in
the checkPhase.

[GO111MODULE=auto] activates the module-aware mode of the go command
whenever the current working directory contains, or is below a
directory containing, a go.mod file — even if the current directory
is within GOPATH/src.

[1] https://golang.org/doc/go1.13#proxy-vars

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ehmry @lethalman

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 14, 2019

that's a lot of rebuilds, staging would be more appropriate

marsam added 2 commits Nov 14, 2019
Go 1.13 slightly changed the behavior GO111MODULE=auto [1], which might
accidentally cause the go command to build the module, for instance in
the checkPhase:

    [GO111MODULE=auto] activates the module-aware mode of the go command
    whenever the current working directory contains, or is below a
    directory containing, a go.mod file — even if the current directory
    is within GOPATH/src.

[1] https://golang.org/doc/go1.13#proxy-vars
We disable module-mode in buildGoPackage
@marsam marsam changed the base branch from master to staging Nov 14, 2019
@marsam marsam force-pushed the marsam:disable-buildGoPackage-module branch from b58fc48 to 87aec65 Nov 14, 2019
@marsam
Copy link
Contributor Author

@marsam marsam commented Nov 14, 2019

Thanks for the heads up, moved base branch to staging

@fpletz
Copy link
Member

@fpletz fpletz commented Nov 14, 2019

Does this change break builds with older Go versions?

@marsam
Copy link
Contributor Author

@marsam marsam commented Nov 14, 2019

It shouldn't, prior to Go 1.13, GO111MODULE=auto does not enable module-mode inside GOPATH https://github.com/golang/go/wiki/Modules#when-do-i-get-old-behavior-vs-new-module-based-behavior

@FRidh FRidh added this to Needs review in Staging Nov 19, 2019
@FRidh FRidh merged commit 490f8ab into NixOS:staging Dec 10, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
documize-community on aarch64-linux Success
Details
documize-community on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Needs review to Done Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.