Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernix: v0.2.0 #73385

Merged
merged 1 commit into from May 1, 2020
Merged

kubernix: v0.2.0 #73385

merged 1 commit into from May 1, 2020

Conversation

@saschagrunert
Copy link
Member

saschagrunert commented Nov 14, 2019

Motivation for this change

Add kubernix to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 14, 2019

@GrahamcOfBorg build kubernix

@jonringer
Copy link
Contributor

jonringer commented Nov 17, 2019

oh, I'm not 100% sure on how to scope tests in rust, I just noticed that all the config::tests ones passed. I knew the command wasn't right :(

@jonringer
Copy link
Contributor

jonringer commented Nov 17, 2019

sorry to bother @grahamc , but I'm not really sure how to scope cargo tests to just a subset of a test suite

@jonringer
Copy link
Contributor

jonringer commented Nov 17, 2019

also, it's hard to find documentation on the matter

@saschagrunert saschagrunert force-pushed the saschagrunert:kubernix branch from eac3f75 to 36bc5f5 Nov 17, 2019
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 17, 2019

also, it's hard to find documentation on the matter

Unfortunately its not that easily possible with the 0.2.0 release. I would suggest in changing this to the next version, where I would split up the independent tests that we can execute them here.

@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 17, 2019

@GrahamcOfBorg build kubernix

Copy link
Contributor

zowoq left a comment

Fixing the tests in the next release sounds fine.

@saschagrunert saschagrunert force-pushed the saschagrunert:kubernix branch from 8f1f640 to 17163dd Apr 29, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 29, 2020

Implemented the review suggestions and rebased on top of the latest master.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert force-pushed the saschagrunert:kubernix branch from 17163dd to c07a467 Apr 29, 2020
@cole-h
Copy link
Member

cole-h commented Apr 29, 2020

@ofborg eval

Looks like the bot got stuck; sorry about that.

@zowoq
zowoq approved these changes Apr 29, 2020
Copy link
Contributor

zowoq left a comment

LGTM, works.

@marsam marsam merged commit 38230fe into NixOS:master May 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c07a467"; rev="c07a4675a3b00cc3c462e1e6cb893cc437f30f4e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c07a467"; rev="c07a4675a3b00cc3c462e1e6cb893cc437f30f4e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c07a467"; rev="c07a4675a3b00cc3c462e1e6cb893cc437f30f4e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c07a467"; rev="c07a4675a3b00cc3c462e1e6cb893cc437f30f4e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c07a467"; rev="c07a4675a3b00cc3c462e1e6cb893cc437f30f4e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c07a467"; rev="c07a4675a3b00cc3c462e1e6cb893cc437f30f4e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c07a467"; rev="c07a4675a3b00cc3c462e1e6cb893cc437f30f4e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kubernix, kubernix.passthru.tests on aarch64-linux Success
Details
kubernix, kubernix.passthru.tests on x86_64-linux Success
Details
@saschagrunert saschagrunert deleted the saschagrunert:kubernix branch May 1, 2020
@PanAeon
Copy link
Contributor

PanAeon commented May 6, 2020

Works against 20.03.1619.ab3adfe1c76 with obligatory cargoSha256 change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.