Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia_x11: i686bundled only on i686 systems #73398

Closed

Conversation

@eadwu
Copy link
Member

eadwu commented Nov 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eadwu

This comment has been minimized.

Copy link
Member Author

eadwu commented Nov 14, 2019

Looks like this was the original intention and I somehow lost it and never had problems until now.

@@ -147,7 +147,7 @@ in {
etc."qemu/bridge.conf".text = lib.concatMapStringsSep "\n" (e:
"allow ${e}") cfg.allowedBridges;
systemPackages = with pkgs; [ libvirt libressl.nc iptables cfg.qemuPackage ];
etc.ethertypes.source = "${iptables}/etc/ethertypes";
etc.ethertypes.source = "${pkgs.iptables}/etc/ethertypes";

This comment has been minimized.

Copy link
@baracoder

baracoder Nov 14, 2019

Contributor

Seams like an unrelated change, which slipped in

@@ -30,7 +30,7 @@ assert ! versionOlder version "391" -> stdenv.hostPlatform.system == "x86_64-lin
let
nameSuffix = optionalString (!libsOnly) "-${kernel.version}";
pkgSuffix = optionalString (versionOlder version "304") "-pkg0";
i686bundled = versionAtLeast version "391";
i686bundled = stdenv.hostPlatform.system == "i686-linux" && versionAtLeast version "391";

This comment has been minimized.

Copy link
@baracoder

baracoder Nov 14, 2019

Contributor

If i remember correctly, 391 is the first driver, where nvidia has dropped support for 32bit driver, and the 32bit libraries for steam games and i686 programs run on x64 are bundled in the x64 package.

@eadwu

This comment has been minimized.

Copy link
Member Author

eadwu commented Nov 20, 2019

Don't know what happened, but the build seems to work fine now.

@eadwu eadwu closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.