Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/syncthing: add versioning #73405

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@mrVanDalo
Copy link
Contributor

mrVanDalo commented Nov 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@mrVanDalo mrVanDalo mentioned this pull request Nov 14, 2019
4 of 10 tasks complete
@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/synthing-versioning branch from 267dd1e to a8f6a29 Nov 14, 2019
@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/synthing-versioning branch from a8f6a29 to f7c026f Nov 14, 2019
@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 14, 2019

Note you can test whether the issue still occurs with

$ nix-build -A metrics pkgs/top-level/release.nix 
@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/synthing-versioning branch 2 times, most recently from 4c86171 to 74b0495 Nov 14, 2019
@mrVanDalo mrVanDalo force-pushed the mrVanDalo:feature/synthing-versioning branch from 74b0495 to fc58c10 Nov 14, 2019
@mrVanDalo

This comment has been minimized.

Copy link
Contributor Author

mrVanDalo commented Nov 14, 2019

Note you can test whether the issue still occurs with

$ nix-build -A metrics pkgs/top-level/release.nix 

which issue?

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 14, 2019

the lack of descriptions broke the metrics job, preventing a channel from advancing

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 14, 2019

Basically, when changing a module, it's good not to just test the module (which I am sure you did), but also this job.

@mrVanDalo

This comment has been minimized.

Copy link
Contributor Author

mrVanDalo commented Nov 15, 2019

I see, when I have some more time (I guess on Monday or Sunday), I will have a look at this metrics job. Never heard of it before, also @GrahamcOfBorg did not post anything. Is this party of https://hydra.nixos.org ? I also couldn't find any information about this in the https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md.

Btw I think the pull request can be merged now.

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 16, 2019

ofborg does not evaluate NixOS tests unfortunately. NixOS/ofborg#315
The metrics job is a channel requirement https://hydra.nixos.org/job/nixpkgs/trunk/unstable#tabs-constituents

@mrVanDalo

This comment has been minimized.

Copy link
Contributor Author

mrVanDalo commented Nov 17, 2019

@FRidh thank your explanation and your links. When I ran the command, you posted, in the branch of my changes, I get this error :

running nix-env -f /nix/store/xq9xlwifn82gvvkqbh6xam7sfyrx7b04-nixpkgs -qa
error: executing '': No such file or directory
{
  "cpuTime": 6.69466,
  "envs": {
    "number": 2508238,
    "elements": 6373342,
    "bytes": 91118544
  },
  "list": {
    "elements": 2231186,
    "bytes": 17849488,
    "concats": 147348
  },
  "values": {
    "number": 8350889,
    "bytes": 200421336
  },
  "symbols": {
    "number": 308128,
    "bytes": 13451059
  },
  "sets": {
    "number": 1506164,
    "bytes": 669575824,
    "elements": 27396938
  },
  "sizes": {
    "Env": 16,
    "Value": 24,
    "Bindings": 8,
    "Attr": 24
  },
  "nrOpUpdates": 897367,
  "nrOpUpdateValuesCopied": 21716914,
  "nrThunks": 6835863,
  "nrAvoided": 3856394,
  "nrLookups": 1944563,
  "nrPrimOpCalls": 895598,
  "nrFunctionCalls": 2133214,
  "gc": {
    "heapSize": 990572544,
    "totalBytes": 1272965408
  }
}
6.85user 0.64system 0:07.49elapsed 99%CPU (0avgtext+0avgdata 1448796maxresident)k
0inputs+72outputs (0major+365520minor)pagefaults 0swaps

parse error: Invalid numeric literal at line 1, column 6
builder for '/nix/store/3y9azq795wf3q99cv2zmm3szzhx6jgfp-nixpkgs-metrics.drv' failed with exit code 4
error: build of '/nix/store/3y9azq795wf3q99cv2zmm3szzhx6jgfp-nixpkgs-metrics.drv' failed

I also get this error on the current origin/master. So I expect it not to be my fault.

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 17, 2019

I noticed it as well, even though the test passes on Hydra! Will need to investigate this further.

Copy link
Contributor

Lassulus left a comment

so lets try this again?

@Lassulus Lassulus merged commit dcdf4ce into NixOS:master Nov 19, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mrVanDalo

This comment has been minimized.

Copy link
Contributor Author

mrVanDalo commented Nov 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.