Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitea: 1.9.5 -> 1.9.6 #73415

Merged
merged 1 commit into from Nov 15, 2019
Merged

gitea: 1.9.5 -> 1.9.6 #73415

merged 1 commit into from Nov 15, 2019

Conversation

@kolaente
Copy link
Contributor

@kolaente kolaente commented Nov 14, 2019

Motivation for this change

Gitea Bugfix release: https://blog.gitea.io/2019/11/gitea-1.9.6-is-released/

Since 1.10 was also released, maybe we should drop this pr in favour of 1.10? See #73416 for the 1.10.0 version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@etu
Copy link
Contributor

@etu etu commented Nov 15, 2019

@GrahamcOfBorg test gitea

I'm thinking that maybe we want 1.9.5 -> 1.9.6 and 1.9.6 -> 1.10.0? We need to decide if we want to backport 1.10.0 to stable or if we want to stick it to the 1.9.X series. If we have the latter we should probably get 1.9.6 in master to be able to cherry-pick that commit.

@etu etu merged commit 962783e into NixOS:master Nov 15, 2019
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gitea on aarch64-linux Success
Details
gitea on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.gitea on aarch64-linux Success
Details
tests.gitea on x86_64-linux Success
Details
@etu etu mentioned this pull request Nov 15, 2019
0 of 10 tasks complete
@flokli flokli mentioned this pull request Nov 17, 2019
4 of 10 tasks complete
@kolaente kolaente deleted the kolaente:update/gitea-1.9.6 branch Nov 18, 2019
@kolaente
Copy link
Contributor Author

@kolaente kolaente commented Nov 18, 2019

IMHO we should put 1.10. in stable, since 1.9.X won't get much support now because 1.10. is out. We (Gitea) simply don't have the resources to provide an LTS version, we're only a community open source project.

@etu etu mentioned this pull request Nov 19, 2019
0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.