Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chez-matchable: init at 1.0 #73419

Merged
merged 2 commits into from Dec 11, 2019
Merged

chez-matchable: init at 1.0 #73419

merged 2 commits into from Dec 11, 2019

Conversation

@jitwit
Copy link
Contributor

@jitwit jitwit commented Nov 14, 2019

Motivation for this change

Adding a package definition for the hygenic pattern matching library developed by Alex Shinn.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pname = "chez-matchable";
version = "1.0";

src = fetchgit {

This comment has been minimized.

@Lassulus

Lassulus Nov 17, 2019
Contributor

maybe use fetchFromGitHub here

This comment has been minimized.

@jitwit

jitwit Nov 18, 2019
Author Contributor

What's the difference?

This comment has been minimized.

@Lassulus

Lassulus Nov 18, 2019
Contributor

fetchFromGitHub fetches the tarball from github, which makes downloads faster

This comment has been minimized.

@jitwit

jitwit Dec 11, 2019
Author Contributor

Sorry for the delay, done! (assuming it looks ok now?)


src = fetchgit {
url = "https://github.com/fedeinthemix/chez-matchable.git";
rev = "73e46432ae70ec72eba6ef116bd84ad9ee38b2f2";

This comment has been minimized.

@doronbehar

doronbehar Dec 6, 2019
Contributor

Also, please use the version as the rev - the Git tag.

This comment has been minimized.

@jitwit

jitwit Dec 11, 2019
Author Contributor

Done! Otherwise it's ok?

Copy link
Contributor

@Lassulus Lassulus left a comment

builds with nix-review, LGTM

EDIT: wait, the version is not 1.0 anymore, can you change the commit message?
EDIT EDIT: ah nvm, I can change it when squasing

@Lassulus Lassulus merged commit bbd6003 into NixOS:master Dec 11, 2019
15 checks passed
15 checks passed
chez-matchable on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
chez-matchable on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jitwit
Copy link
Contributor Author

@jitwit jitwit commented Dec 11, 2019

builds with nix-review, LGTM

EDIT: wait, the version is not 1.0 anymore, can you change the commit message?
EDIT EDIT: ah nvm, I can change it when squasing

Ach, sorry for missing that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.