Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop: 1.27.4 -> 1.28.0 #73426

Merged
merged 3 commits into from Nov 15, 2019
Merged

signal-desktop: 1.27.4 -> 1.28.0 #73426

merged 3 commits into from Nov 15, 2019

Conversation

@equirosa
Copy link
Contributor

@equirosa equirosa commented Nov 14, 2019

Motivation for this change

Version 1.28.0 of the signal-desktop app has been released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

@mmahut mmahut commented Nov 15, 2019

@GrahamcOfBorg build signal-desktop

@mmahut
Copy link
Member

@mmahut mmahut commented Nov 15, 2019

Thank you. Welcome to nixpkgs :)

@mmahut mmahut merged commit 2b488b3 into NixOS:master Nov 15, 2019
15 checks passed
15 checks passed
signal-desktop on aarch64-linux No attempt
Details
signal-desktop on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
signal-desktop on x86_64-linux Success
Details
@mmahut
Copy link
Member

@mmahut mmahut commented Nov 15, 2019

Backported already in dd00d0f.

@equirosa
Copy link
Contributor Author

@equirosa equirosa commented Nov 15, 2019

Thank you. Welcome to nixpkgs :)
Happy to help! :)

@primeos
Copy link
Member

@primeos primeos commented Dec 5, 2019

Just noticed this, why wasn't I notified as the maintainer (@GrahamcOfBorg probably skipped it as there was no actual change)?

This update was already in master (7b77666) and this package is actively maintained.
So there was actually no need for this PR (no-op merge). But of course this doesn't really hurt, it's just confusing.

@equirosa thanks for your PR and welcome to nixpkgs. But if possible please focus on unmaintained packages that actually need a maintainer. Unfortunately we have quite a few of those and could need some help :)

@mmahut
Copy link
Member

@mmahut mmahut commented Dec 5, 2019

@primeos I am a little bit confused, was the commit 7b77666 merged without a pull request?

@equirosa
Copy link
Contributor Author

@equirosa equirosa commented Dec 5, 2019

@equirosa thanks for your PR and welcome to nixpkgs. But if possible please focus on unmaintained packages that actually need a maintainer. Unfortunately we have quite a few of those and could need some help :)

Understood! Will attempt to help where I can! 😄

@primeos
Copy link
Member

@primeos primeos commented Dec 6, 2019

@primeos I am a little bit confused, was the commit 7b77666 merged without a pull request?

Yes, I pushed it directly.

Will attempt to help where I can!

Awesome, thanks :)

@rht
Copy link
Member

@rht rht commented Jan 17, 2020

There is a nasty bug for Signal <=1.29.5 signalapp/Signal-Desktop#3879 that is fixed in the latest version 1.29.6. @equirosa do you have the time to bump the version up once again?

@rht
Copy link
Member

@rht rht commented Jan 17, 2020

Nvm, I have made #77924.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.