Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "python37Packages.pyspf: 2.0.12 -> 2.0.13" #73427

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Nov 14, 2019

This reverts commit e3f9c4d.
This fixes #72791.
Version 2.0.13 introduced a bug where some incoming mails can cause a
crash and be falsely rejected. (sdgathman/pyspf#17)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@petabyteboy petabyteboy requested review from FRidh and jonringer as code owners Nov 14, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Nov 14, 2019

Could you include a comment next to the version info that 2.0.13 should not be used. That way we likely notice it when the bot proposes the change again.

@ofborg ofborg bot added the 6.topic: python label Nov 14, 2019
@ofborg ofborg bot requested a review from abbradar Nov 14, 2019
@petabyteboy petabyteboy force-pushed the petabyteboy:feature/pyspf branch from 1576082 to f6ebecf Nov 14, 2019
@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Nov 14, 2019

Could you include a comment next to the version info that 2.0.13 should not be used. That way we likely notice it when the bot proposes the change again.

Good idea, done.

This reverts commit e3f9c4d.
This fixes #72791.
Version 2.0.13 of pyspf introduced a bug where some incoming mails can cause a
crash and be falsely rejected. (sdgathman/pyspf#17)
@petabyteboy petabyteboy force-pushed the petabyteboy:feature/pyspf branch from f6ebecf to 00a3aa9 Nov 14, 2019
Copy link
Contributor

@jonringer jonringer left a comment

nix-review passes on NixOS
intention seems reasonable

https://github.com/NixOS/nixpkgs/pull/73427
4 package were build:
pypolicyd-spf python27Packages.pyspf python37Packages.pyspf python38Packages.pyspf
@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 15, 2019

@GrahamcOfBorg build pypolicyd-spf python27Packages.pyspf python37Packages.pyspf python38Packages.pyspf

@jonringer jonringer merged commit dafbcb9 into NixOS:master Nov 15, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pypolicyd-spf, python27Packages.pyspf, python37Packages.pyspf, python38Packages.pyspf on aarch64-linux Success
Details
pypolicyd-spf, python27Packages.pyspf, python37Packages.pyspf, python38Packages.pyspf on x86_64-darwin Success
Details
pypolicyd-spf, python27Packages.pyspf, python37Packages.pyspf, python38Packages.pyspf on x86_64-linux Success
Details
Infinisil added a commit to Infinisil/system that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.