Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.03] pythonPackages.cherrypy: fix build #73432

Closed
wants to merge 1 commit into from

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Nov 15, 2019

Motivation for this change

I realize 19.03 is long in the tooth, but the recent minor bump to its python releases broke cherrypy and all its depending packages. Let's not leave it broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Nov 16, 2019

So this only applies to 19.03? Can you document that in the commit message?

@risicle
Copy link
Contributor Author

@risicle risicle commented Nov 16, 2019

I think it was fixed similarly in mainline: d57d67e - I'll add this info to the commit message.

recent python releases have problems with test_null_bytes. see
cherrypy/cherrypy#1781

analogous to mainline's fix @ d57d67e
@risicle risicle force-pushed the risicle:ris-cherrypy-fix-r19.03 branch from 3864335 to bc50af1 Nov 16, 2019
@ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 17, 2019

The v17 version of cherrypy we have is still broken on 19.09 and master. There are several packages broken on 19.09 due to this. Master on the other hand I think has indirectly v17 disabled likely due to a phasing out of python2 in preparation for it's 2020 EOL. Edit: Maybe not, but it isn't being built by hydra

Both the patch on this PR and the one in d57d67e when ported fix release-19.09 (and likely master too if it was possible to build)

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 17, 2019

I see that python37 build works on hydra for darwin https://hydra.nixos.org/build/106807015 the python38 build seems to be broken by aiohttp

@veprbl
Copy link
Member

@veprbl veprbl commented Mar 30, 2020

Is this still relevant?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 31, 2020

I would say no, 19.09 is already near EOL, and 20.03 is about to be released.

@risicle thank you for opening the PR though :)

@jonringer jonringer closed this Mar 31, 2020
@veprbl
Copy link
Member

@veprbl veprbl commented Mar 31, 2020

@jonringer This is all implied of course. I was thinking that we should not completely discourage motivated individuals from backporting fixes to the older releases. However, they should keep in mind that: first, they would need to do most of the work of proving that the changes are safe, and, second, that the EOL channels often get blocked and may not advance to the newer commits without some additional fixes to other parts of NixOS.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 31, 2020

I completely agree.

If this was targeting the 19.09 branch, i would have reviewed and merged as usual. But currently if someone were to raise an issue against 19.03, we would likely tell the use to use 19.09 as 19.03 is no longer supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.