Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] lorri: init at unstable-2019-10-30 (backport) #73451

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Nov 15, 2019

backport of the lorri release (#72889)

This is strictly an improvement over the error message we threw before for lorri.

cc @curiousleo

@Profpatsch Profpatsch requested a review from flokli Nov 15, 2019
@Profpatsch Profpatsch requested a review from Infinisil as a code owner Nov 15, 2019
@flokli
Copy link
Contributor

@flokli flokli commented Nov 15, 2019

@GrahamcOfBorg test lorri

@@ -0,0 +1,26 @@
import ../make-test-python.nix {

This comment has been minimized.

@flokli

flokli Nov 15, 2019
Contributor

The VM test doesn't pass, as the python test runner didn't exist in 19.09 yet. However, porting that to the perl code should be straightforward - can you port testScript to perl?

@Profpatsch
Copy link
Member Author

@Profpatsch Profpatsch commented Nov 15, 2019

However, porting that to the perl code should be straightforward - can you port testScript to perl?

Let’s just remove the test in the backport, so that we don’t have to backport them any time we improve them on master.

@ofborg ofborg bot requested a review from grahamc Nov 15, 2019
@Profpatsch Profpatsch force-pushed the Profpatsch:lorri-init-backport-19.09 branch from f99324a to 2e62017 Nov 15, 2019
@Profpatsch
Copy link
Member Author

@Profpatsch Profpatsch commented Nov 15, 2019

@GrahamcOfBorg build lorri

Removed the test

curiousleo added 2 commits Nov 5, 2019
(cherry picked from commit e5db97d)
@flokli flokli force-pushed the Profpatsch:lorri-init-backport-19.09 branch from 2e62017 to 762df65 Nov 15, 2019
@flokli
Copy link
Contributor

@flokli flokli commented Nov 15, 2019

I disagree with dropping the test.

It's trivial to port, and if we want to advertise lorris usability on the current stable release, we should ensure it works there - even if this means a little bit more backporting work.

The cherry-picks missed the -x aswell, so I cherry-pick -x-ed again and while doing so, ported the test to perl aswell. PTAL.

@flokli
Copy link
Contributor

@flokli flokli commented Nov 15, 2019

@GrahamcOfBorg test lorri

@flokli
flokli approved these changes Nov 15, 2019
@flokli flokli changed the title Lorri init backport 19.09 [19.09] lorri: init at unstable-2019-10-30 (backport) Nov 15, 2019
@Profpatsch Profpatsch merged commit eda44a6 into NixOS:release-19.09 Nov 15, 2019
12 of 14 checks passed
12 of 14 checks passed
grahamcofborg-eval Calculating Changed Outputs
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.lorri on aarch64-linux Success
Details
tests.lorri on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.